qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/24] bsd-user/arm/target_arch_cpu.h: Implement system call


From: Warner Losh
Subject: Re: [PATCH 09/24] bsd-user/arm/target_arch_cpu.h: Implement system call dispatch
Date: Thu, 28 Oct 2021 11:56:03 -0600



On Thu, Oct 28, 2021 at 9:35 AM Richard Henderson <richard.henderson@linaro.org> wrote:
On 10/19/21 9:44 AM, Warner Losh wrote:
> +                env->eabi = 1; /* FreeBSD is eabi only now */

Surely this should be set target_cpu_init.  Even then it'd be just for completeness.  This
is the kind of thing that shouldn't have escaped linux-user, as it's otherwise unused.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

I see no other uses outside of linux-user, so I'm just going to delete this line. FreeBSD
used to support OABI in bsd-user, but always badly and so that code was removed.

Warner 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]