[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/9] hw/scsi/megasas: Simplify using the ldst API
From: |
Laurent Vivier |
Subject: |
[PULL 2/9] hw/scsi/megasas: Simplify using the ldst API |
Date: |
Tue, 18 Jan 2022 13:28:40 +0100 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
This code is easier to review using the load/store API.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20211218111912.1499377-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/scsi/megasas.c | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index dc9bbdb740e7..83c321ec208a 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -383,8 +383,7 @@ static int megasas_setup_inquiry(uint8_t *cdb, int pg, int
len)
cdb[1] = 0x1;
cdb[2] = pg;
}
- cdb[3] = (len >> 8) & 0xff;
- cdb[4] = (len & 0xff);
+ stw_be_p(&cdb[3], len);
return len;
}
@@ -400,18 +399,8 @@ static void megasas_encode_lba(uint8_t *cdb, uint64_t lba,
} else {
cdb[0] = READ_16;
}
- cdb[2] = (lba >> 56) & 0xff;
- cdb[3] = (lba >> 48) & 0xff;
- cdb[4] = (lba >> 40) & 0xff;
- cdb[5] = (lba >> 32) & 0xff;
- cdb[6] = (lba >> 24) & 0xff;
- cdb[7] = (lba >> 16) & 0xff;
- cdb[8] = (lba >> 8) & 0xff;
- cdb[9] = (lba) & 0xff;
- cdb[10] = (len >> 24) & 0xff;
- cdb[11] = (len >> 16) & 0xff;
- cdb[12] = (len >> 8) & 0xff;
- cdb[13] = (len) & 0xff;
+ stq_be_p(&cdb[2], lba);
+ stl_be_p(&cdb[2 + 8], len);
}
/*
--
2.34.1
- [PULL 0/9] Trivial branch for 7.0 patches, Laurent Vivier, 2022/01/18
- [PULL 3/9] qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ, Laurent Vivier, 2022/01/18
- [PULL 2/9] hw/scsi/megasas: Simplify using the ldst API,
Laurent Vivier <=
- [PULL 4/9] tests: Fix typo in check-help output, Laurent Vivier, 2022/01/18
- [PULL 6/9] linux-user: Fix comment typo in arm cpu_loop code, Laurent Vivier, 2022/01/18
- [PULL 7/9] linux-user: Rename user_force_sig tracepoint to match function name, Laurent Vivier, 2022/01/18
- [PULL 9/9] linux-user: Remove MAX_SIGQUEUE_SIZE, Laurent Vivier, 2022/01/18
- [PULL 8/9] linux-user: Return void from queue_signal(), Laurent Vivier, 2022/01/18
- [PULL 1/9] hw/timer/etraxfs_timer: Add vmstate for ETRAX timers, Laurent Vivier, 2022/01/18
- [PULL 5/9] softmmu: Provide a clue as to why device tree loading failed, Laurent Vivier, 2022/01/18
- Re: [PULL 0/9] Trivial branch for 7.0 patches, Peter Maydell, 2022/01/19