[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/lcitool: Do not use a hard-coded /usr/bin/python3 as p

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] tests/lcitool: Do not use a hard-coded /usr/bin/python3 as python interpreter
Date: Tue, 29 Mar 2022 12:18:31 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

On 29/3/22 08:39, Thomas Huth wrote:
When running "make lcitool-refresh", this currently uses the hard-coded
/usr/bin/python3 from the script's shebang line for running Python.
That's bad, since neither /usr/bin/python3 is guaranteed to exist, nor
does it honor the python interpreter that the user might have chosen
while running the "configure" script. Thus let's rather use $(PYTHON)
in the Makefile, and improve the shebang line in the script in case
someone runs this directly.

Signed-off-by: Thomas Huth <thuth@redhat.com>
  tests/lcitool/Makefile.include | 2 +-
  tests/lcitool/refresh          | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]