[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-7.0] meson.build: Fix dependency of page-vary-common.c to

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH for-7.0] meson.build: Fix dependency of page-vary-common.c to config-poison.h
Date: Wed, 30 Mar 2022 14:05:16 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

Hi Thomas,

On 30/3/22 13:48, Thomas Huth wrote:
Before compiling page-vary-common.c, we have to make sure that
config-poison.h has been generated (which is in the "genh" list).

I am a bit confused, "config-poison.h" is include by "exec/poison.h"
which is included by "qemu/osdep.h" for all non-softmmu code (tools,
common and -user).

Why is pagevary specific? Shouldn't add genh to all common_ss[]?

Maybe the problem is how common_all[] is created?

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/948
Signed-off-by: Thomas Huth <thuth@redhat.com>
  meson.build | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index aef724ad3c..04ce33fef1 100644
--- a/meson.build
+++ b/meson.build
@@ -2881,7 +2881,7 @@ if get_option('b_lto')
    if get_option('cfi')
      pagevary_flags += '-fno-sanitize=cfi-icall'
-  pagevary = static_library('page-vary-common', sources: pagevary,
+  pagevary = static_library('page-vary-common', sources: pagevary + genh,
                              c_args: pagevary_flags)
    pagevary = declare_dependency(link_with: pagevary)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]