qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] linux-user/sh4/termbits: Silence warning about TIOCSER_TEMT


From: Laurent Vivier
Subject: Re: [PATCH] linux-user/sh4/termbits: Silence warning about TIOCSER_TEMT double definition
Date: Wed, 30 Mar 2022 16:37:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

Le 30/03/2022 à 15:43, Thomas Huth a écrit :
Seen while compiling on Alpine:

  In file included from ../linux-user/strace.c:17:
  In file included from ../linux-user/qemu.h:11:
  In file included from ../linux-user/syscall_defs.h:1247:
  ../linux-user/sh4/termbits.h:276:10: warning: 'TIOCSER_TEMT' macro redefined
   [-Wmacro-redefined]
  # define TIOCSER_TEMT    0x01   /* Transmitter physically empty */
           ^
  /usr/include/sys/ioctl.h:50:9: note: previous definition is here
  #define TIOCSER_TEMT 1
          ^
  1 warning generated.

Add the TARGET_ prefix here, too, like we do it on the other architectures.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  linux-user/sh4/termbits.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/sh4/termbits.h b/linux-user/sh4/termbits.h
index f91b5c51cf..eeabd2d7a9 100644
--- a/linux-user/sh4/termbits.h
+++ b/linux-user/sh4/termbits.h
@@ -273,7 +273,7 @@ ebugging only */
  #define TARGET_TIOCSERGETLSR   TARGET_IOR('T', 89, unsigned int) /* 0x5459 */ 
/* Get line sta
  tus register */
    /* ioctl (fd, TIOCSERGETLSR, &result) where result may be as below */
-# define TIOCSER_TEMT    0x01   /* Transmitter physically empty */
+# define TARGET_TIOCSER_TEMT   0x01   /* Transmitter physically empty */
  #define TARGET_TIOCSERGETMULTI TARGET_IOR('T', 90, int) /* 0x545A
  */ /* Get multiport config  */
  #define TARGET_TIOCSERSETMULTI TARGET_IOW('T', 91, int) /* 0x545B

Reviewed-by: Laurent Vivier <laurent@vivier.eu>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]