[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-7.0] meson.build: Fix dependency of page-vary-common.c to

From: Paolo Bonzini
Subject: Re: [PATCH for-7.0] meson.build: Fix dependency of page-vary-common.c to config-poison.h
Date: Wed, 30 Mar 2022 17:03:33 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

On 3/30/22 14:05, Philippe Mathieu-Daudé wrote:
Shouldn't add genh to all common_ss[]?

Maybe the problem is how common_all[] is created?

Generated headers have to be added to all sourcesets, or to all targets.

common_ss is only used to build the object files in libcommon.fa.p, but libcommon.fa also includes many other .fa build targets (via "dependencies:"). All those build targets also need to have genh in their build target as well, otherwise their object files might be built before the generated headers.

(The other question then is why we have libauthz, libcrypto, libmigration, etc. instead of just using the sourcesets. The answer for that is that in Meson the static_library is the tool for object file reuse. If you include the same source file in many different executable it is recompiled. Therefore, if you used sourcesets, you would build the object files once for each testsuite program that uses them).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]