[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/10] hw/i386: Select E1000_PCI for i440fx

From: Thomas Huth
Subject: Re: [PATCH 04/10] hw/i386: Select E1000_PCI for i440fx
Date: Tue, 7 Feb 2023 19:16:34 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 06/02/2023 15.08, Fabiano Rosas wrote:
The i440fx machines uses the e1000 adapter as the default when no
other network card is configured.

Move the E1000_PCI entry in Kconfig from 'imply' to 'select' to avoid
the following situation:

./qemu-system-i386 -machine pc-i440fx-8.0
qemu-system-i386: Unsupported NIC model: e1000

Signed-off-by: Fabiano Rosas <farosas@suse.de>
  hw/i386/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index 8e59cb6634..343783ea3e 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -66,7 +66,6 @@ config PC_ACPI
config I440FX
-    imply E1000_PCI
      imply VMPORT
      imply VMMOUSE
      select ACPI_PIIX4
@@ -78,6 +77,7 @@ config I440FX
      select DIMM
      select SMBIOS
      select FW_CFG_DMA
+    select E1000_PCI

Reviewed-by: Thomas Huth <thuth@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]