[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] include/hw: Do not include hw.h from headers

From: Thomas Huth
Subject: Re: [PATCH] include/hw: Do not include hw.h from headers
Date: Fri, 10 Feb 2023 14:00:56 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 10/02/2023 13.45, Philippe Mathieu-Daudé wrote:
On 10/2/23 12:28, Thomas Huth wrote:
This include is not needed here, so drop that line.

Signed-off-by: Thomas Huth <thuth@redhat.com>
  include/hw/ssi/ibex_spi_host.h          | 1 -
  include/hw/tricore/tricore_testdevice.h | 1 -
  2 files changed, 2 deletions(-)

Possibly more?

$ git grep hw/hw.h $(git grep -L -w hw_error)
hw/pci-host/mv64361.c:14:#include "hw/hw.h"
hw/ppc/pegasos2.c:13:#include "hw/hw.h"
hw/sensor/dps310.c:12:#include "hw/hw.h"
include/hw/ssi/ibex_spi_host.h:31:#include "hw/hw.h"
include/hw/tricore/tricore_testdevice.h:22:#include "hw/hw.h"

Oh, I only looked at the headers in include/ ... but you're right, these other files also don't need it. Thanks, I'll send a v2.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]