[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 3/9] hw/i386/pc_q35: Reuse machine parameter

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v4 3/9] hw/i386/pc_q35: Reuse machine parameter
Date: Wed, 22 Feb 2023 12:03:38 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 13/2/23 17:19, Bernhard Beschow wrote:
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
  hw/i386/pc_q35.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 66cd718b70..dee2b38474 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -218,7 +218,7 @@ static void pc_q35_init(MachineState *machine)
      pc_memory_init(pcms, get_system_memory(), rom_memory, &ram_memory,
- object_property_add_child(qdev_get_machine(), "q35", OBJECT(q35_host));
+    object_property_add_child(OBJECT(machine), "q35", OBJECT(q35_host));
      object_property_set_link(OBJECT(q35_host), MCH_HOST_PROP_RAM_MEM,
                               OBJECT(ram_memory), NULL);
      object_property_set_link(OBJECT(q35_host), MCH_HOST_PROP_PCI_MEM,

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Long term we should duplicate/extract Q35MachineState from
PCMachineState and add a Q35PCIHost field, then use object_initialize_child; removing this object_property_add_child()

reply via email to

[Prev in Thread] Current Thread [Next in Thread]