[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cirrus.yml: Cover SPICE in the MSYS2 job

From: Thomas Huth
Subject: Re: [PATCH] cirrus.yml: Cover SPICE in the MSYS2 job
Date: Wed, 22 Mar 2023 12:30:25 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 22/03/2023 12.05, Philippe Mathieu-Daudé wrote:
Include the mingw-w64-x86_64-spice package so SPICE is covered:

   C compiler for the host machine: cc -m64 -mcx16 (gcc 12.2.0 "cc (Rev10, Built by 
MSYS2 project) 12.2.0")
   Run-time dependency spice-protocol found: YES 0.14.4
   Run-time dependency spice-server found: YES 0.15.1

In particular this would have helped catching the build issue
reported as https://gitlab.com/qemu-project/qemu/-/issues/1553:

Well, hardly anybody is looking at the output on cirrus-ci.com, so this patch here likely would not have prevented the merging of this bug... for that, you rather have to add it to .gitlab-ci.d/windows.yml instead.

But anyway, the patch here is still a good idea, too, so:

Reviewed-by: Thomas Huth <thuth@redhat.com>

   [1851/5253] Compiling C object libcommon.fa.p/ui_spice-core.c.obj
   FAILED: libcommon.fa.p/ui_spice-core.c.obj
   ../ui/spice-core.c: In function 'watch_remove':
   ../ui/spice-core.c:152:5: error: implicit declaration of function 
'qemu_close_to_socket' [-Werror=implicit-function-declaration]
   152 |     qemu_close_to_socket(watch->fd);
       |     ^~~~~~~~~~~~~~~~~~~~
   ../ui/spice-core.c:152:5: error: nested extern declaration of 
'qemu_close_to_socket' [-Werror=nested-externs]

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
See https://cirrus-ci.com/task/6189732569284608?logs=main#L891

Based-on: <20230322075256.2043812-1-marcandre.lureau@redhat.com>
  .cirrus.yml | 1 +
  1 file changed, 1 insertion(+)

diff --git a/.cirrus.yml b/.cirrus.yml
index 5fb00da73d..eb1640814d 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -41,6 +41,7 @@ windows_msys2_task:
+      mingw-w64-x86_64-spice

reply via email to

[Prev in Thread] Current Thread [Next in Thread]