[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/ppc/openpic: Do not open-code ROUND_UP() macro

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] hw/ppc/openpic: Do not open-code ROUND_UP() macro
Date: Fri, 2 Jun 2023 11:29:24 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

There is no generic PPC section in MAINTAINERS covering include/hw/ppc/,
so Cc'ing qemu-ppc@ manually.

Daniel, can you take this (reviewed) patch?



On 23/5/23 08:15, Philippe Mathieu-Daudé wrote:
While reviewing, the ROUND_UP() macro is easier to figure out.
Besides, the comment confirms we want to round up here.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
  include/hw/ppc/openpic.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/hw/ppc/openpic.h b/include/hw/ppc/openpic.h
index ebdaf8a493..bae8dafe16 100644
--- a/include/hw/ppc/openpic.h
+++ b/include/hw/ppc/openpic.h
@@ -55,7 +55,7 @@ typedef enum IRQType {
   * Round up to the nearest 64 IRQs so that the queue length
   * won't change when moving between 32 and 64 bit hosts.
-#define IRQQUEUE_SIZE_BITS ((OPENPIC_MAX_IRQ + 63) & ~63)
typedef struct IRQQueue {
      unsigned long *queue;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]