[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] meson.build: Use -Wno-undef only for SDL2 versions that n

From: Richard Henderson
Subject: Re: [PATCH v2] meson.build: Use -Wno-undef only for SDL2 versions that need it
Date: Fri, 2 Jun 2023 20:30:58 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 6/2/23 09:34, Thomas Huth wrote:
There is no need to disable this useful compiler warning for
all versions of the SDL. Unfortunately, various versions are
buggy (beside SDL 2.0.8, the version 2.26.0 and 2.26.1 are
broken, too, seehttps://github.com/libsdl-org/SDL/issues/6619  ),
but we can use a simple compiler check to see whether we need
the -Wno-undef or not.

This also enables the printing of the version number with
good versions of the SDL in the summary of the meson output

Signed-off-by: Thomas Huth<thuth@redhat.com>
  v2: Compile test code instead of hard-coding the version number

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]