[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] hw/char/parallel-isa: Export struct ISAParallelState

From: BALATON Zoltan
Subject: Re: [PATCH 2/2] hw/char/parallel-isa: Export struct ISAParallelState
Date: Mon, 12 Jun 2023 12:06:30 +0200 (CEST)

On Mon, 12 Jun 2023, Bernhard Beschow wrote:
Am 11. Juni 2023 13:15:58 UTC schrieb BALATON Zoltan <balaton@eik.bme.hu>:
On Sun, 11 Jun 2023, Bernhard Beschow wrote:
Allows the struct to be embedded directly into device models without additional

Suggested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Patches missing SoB, checkpatch should have cought this.

Thanks for catching again. Fixed in v2.

I don't see any of the machines or device models actually embedding ISAParallelState or ParallelState so don't know what this patch is trying to achieve. Please post the whole series with the patches that this is a preparation for so we can se where this leads.

No further plans from my side.

Then IMO these patches are not needed. Keeping the struct definitions in parallel.c ensures they are not accessed by anything else and keeps the object encapsulation. I don't see a point for moving the defs to a header if nothing wants to use them. This is done for other devices to allow them to be embedded in other devices but if that's not the case here then why this series? (The TYPE_ISA_PARALLEL #define seems to be already in include/hw/chsr/parallel.h so if you only want to use that like in the series you've referenced in the cover letter then that can be done without these patches.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]