qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] docs/devel: Fix coding style in style.rst


From: Markus Armbruster
Subject: Re: [PATCH] docs/devel: Fix coding style in style.rst
Date: Mon, 10 Jul 2023 11:49:49 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Thomas Huth <thuth@redhat.com> writes:

> As defined earlier in this file, the opening curly brace of
> functions should be placed on a separate line. So we should
> do it in the examples here, too.
>
> Reported-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> Fixes: 821f296756 ("docs: document use of automatic cleanup functions in 
> glib")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  docs/devel/style.rst | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/docs/devel/style.rst b/docs/devel/style.rst
> index aa5e083ff8..3cfcdeb9cd 100644
> --- a/docs/devel/style.rst
> +++ b/docs/devel/style.rst
> @@ -567,7 +567,8 @@ For example, instead of
>  
>  .. code-block:: c
>  
> -    int somefunc(void) {
> +    int somefunc(void)
> +    {
>          int ret = -1;
>          char *foo = g_strdup_printf("foo%", "wibble");
>          GList *bar = .....
> @@ -588,7 +589,8 @@ Using g_autofree/g_autoptr enables the code to be written 
> as:
>  
>  .. code-block:: c
>  
> -    int somefunc(void) {
> +    int somefunc(void)
> +    {
>          g_autofree char *foo = g_strdup_printf("foo%", "wibble");
>          g_autoptr (GList) bar = .....
>  
> @@ -613,7 +615,8 @@ are still some caveats to beware of
>  
>  .. code-block:: c
>  
> -    char *somefunc(void) {
> +    char *somefunc(void)
> +    {
>          g_autofree char *foo = g_strdup_printf("foo%", "wibble");
>          g_autoptr (GList) bar = .....

Reviewed-by: Markus Armbruster <armbru@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]