[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/2] kvm: replace fprintf with error_report()/printf() in
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v5 1/2] kvm: replace fprintf with error_report()/printf() in kvm_init() |
Date: |
Wed, 28 Aug 2024 15:16:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Ani Sinha <anisinha@redhat.com> writes:
>> On 28 Aug 2024, at 4:53 PM, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Ani Sinha <anisinha@redhat.com> writes:
>>
>>> error_report() is more appropriate for error situations. Replace fprintf
>>> with
>>> error_report() and error_printf() as appropriate. Cosmetic. No functional
>>> change.
>>
>> Uh, I missed this last time around: the change is more than just
>> cosmetics! The error messages change, e.g. from
>>
>> $ qemu-system-x86_64 -nodefaults -S -display none --accel kvm
>> qemu-system-x86_64: --accel kvm: Could not access KVM kernel module:
>> Permission denied
>> qemu-system-x86_64: --accel kvm: failed to initialize kvm: Permission
>> denied
>>
>> to
>>
>> $ qemu-system-x86_64 -nodefaults -S -display none --accel kvm
>> Could not access KVM kernel module: Permission denied
>> qemu-system-x86_64: --accel kvm: failed to initialize kvm: Permission
>> denied
>
> You got this backwards. This is what I have:
I do! Sorry %-}
[...]