Re: [PATCH] fix SSE2/SSSE3 feature detection in tcg/decode-new.c.inc

[Michael Tokarev]

17.06.2024 15:51, Michael Tokarev wrote:
> Adding Cc's.

A friendly ping?  This patch does not apply directly currently, but
the change is still relevant (I can fix context at apply time).

Before it can be applied to trivial-patches tree I'd love to have
some Reviewed-by tag(s).  Or drop it :)

This change is sitting here since May-24.

Thanks,

/mjt

> 29.05.2024 16:53, Frank Mehnert wrote:
> > The correct bitmask is cpuid_features rather than cpuid_ext_features.
> > ---
> >   target/i386/tcg/decode-new.c.inc | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc
> > index 27dc1bb146..0ec849b003 100644
> > --- a/target/i386/tcg/decode-new.c.inc
> > +++ b/target/i386/tcg/decode-new.c.inc
> > @@ -2041,9 +2041,9 @@ static bool has_cpuid_feature(DisasContext *s, 
> > X86CPUIDFeature cpuid)
> >       case X86_FEAT_PCLMULQDQ:
> >           return (s->cpuid_ext_features & CPUID_EXT_PCLMULQDQ);
> >       case X86_FEAT_SSE:
> > -        return (s->cpuid_ext_features & CPUID_SSE);
> > +        return (s->cpuid_features & CPUID_SSE);
> >       case X86_FEAT_SSE2:
> > -        return (s->cpuid_ext_features & CPUID_SSE2);
> > +        return (s->cpuid_features & CPUID_SSE2);
> >       case X86_FEAT_SSE3:
> >           return (s->cpuid_ext_features & CPUID_EXT_SSE3);
> >       case X86_FEAT_SSSE3: