[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] target/hexagon: Rename macros.inc -> macros.h.inc
From: |
Anton Johansson |
Subject: |
Re: [PATCH 1/2] target/hexagon: Rename macros.inc -> macros.h.inc |
Date: |
Tue, 10 Sep 2024 16:21:36 +0200 |
On 10/09/24, Philippe Mathieu-Daudé wrote:
> Since commits 139c1837db ("meson: rename included C source files
> to .c.inc") and 0979ed017f ("meson: rename .inc.h files to .h.inc"),
> EMU standard procedure for included header files is to use *.h.inc.
>
> Besides, since commit 6a0057aa22 ("docs/devel: make a statement
> about includes") this is documented in the Coding Style:
>
> If you do use template header files they should be named with
> the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are
> being included for expansion.
>
> Therefore rename "macros.inc" as "macros.h.inc".
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/hexagon/idef-parser/README.rst | 4 ++--
> target/hexagon/idef-parser/{macros.inc => macros.h.inc} | 0
> target/hexagon/gen_idef_parser_funcs.py | 2 +-
> target/hexagon/meson.build | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
> rename target/hexagon/idef-parser/{macros.inc => macros.h.inc} (100%)
>
Reviewed-by: Anton Johansson <anjo@rev.ng>