[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 16/22] target/hexagon: Rename macros.inc -> macros.h.inc
From: |
Michael Tokarev |
Subject: |
[PULL 16/22] target/hexagon: Rename macros.inc -> macros.h.inc |
Date: |
Fri, 20 Sep 2024 10:41:28 +0300 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Since commits 139c1837db ("meson: rename included C source files
to .c.inc") and 0979ed017f ("meson: rename .inc.h files to .h.inc"),
EMU standard procedure for included header files is to use *.h.inc.
Besides, since commit 6a0057aa22 ("docs/devel: make a statement
about includes") this is documented in the Coding Style:
If you do use template header files they should be named with
the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are
being included for expansion.
Therefore rename "macros.inc" as "macros.h.inc".
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Brian Cain <bcain@quicinc.com>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
target/hexagon/gen_idef_parser_funcs.py | 2 +-
target/hexagon/idef-parser/README.rst | 4 ++--
target/hexagon/idef-parser/{macros.inc => macros.h.inc} | 0
target/hexagon/meson.build | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
rename target/hexagon/idef-parser/{macros.inc => macros.h.inc} (100%)
diff --git a/target/hexagon/gen_idef_parser_funcs.py
b/target/hexagon/gen_idef_parser_funcs.py
index eb494abba8..72f11c68ca 100644
--- a/target/hexagon/gen_idef_parser_funcs.py
+++ b/target/hexagon/gen_idef_parser_funcs.py
@@ -50,7 +50,7 @@ def main():
tagimms = hex_common.get_tagimms()
with open(sys.argv[-1], "w") as f:
- f.write('#include "macros.inc"\n\n')
+ f.write('#include "macros.h.inc"\n\n')
for tag in hex_common.tags:
## Skip the priv instructions
diff --git a/target/hexagon/idef-parser/README.rst
b/target/hexagon/idef-parser/README.rst
index d0aa34309b..7199177ee3 100644
--- a/target/hexagon/idef-parser/README.rst
+++ b/target/hexagon/idef-parser/README.rst
@@ -138,7 +138,7 @@ we obtain the pseudo code
with macros such as ``fJUMPR`` intact.
The second step is to expand macros into a form suitable for our parser.
-These macros are defined in ``idef-parser/macros.inc`` and the step is
+These macros are defined in ``idef-parser/macros.h.inc`` and the step is
carried out by the ``prepare`` script which runs the C preprocessor on
``idef_parser_input.h.inc`` to produce
``idef_parser_input.preprocessed.h.inc``.
@@ -266,7 +266,7 @@ in plain C is defined as
#define fABS(A) (((A) < 0) ? (-(A)) : (A))
and returns the absolute value of the argument ``A``. This macro is not
included
-in ``idef-parser/macros.inc`` and as such is not expanded and kept as a "call"
+in ``idef-parser/macros.h.inc`` and as such is not expanded and kept as a
"call"
``fABS(...)``. Reason being, that ``fABS`` is easier to match and map to
``tcg_gen_abs_<width>``, compared to the full ternary expression above. Loads
of
macros in ``macros.h`` are kept unexpanded to aid in parsing, as seen in the
diff --git a/target/hexagon/idef-parser/macros.inc
b/target/hexagon/idef-parser/macros.h.inc
similarity index 100%
rename from target/hexagon/idef-parser/macros.inc
rename to target/hexagon/idef-parser/macros.h.inc
diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build
index 9ea1f4fc59..f1723778a6 100644
--- a/target/hexagon/meson.build
+++ b/target/hexagon/meson.build
@@ -284,7 +284,7 @@ if idef_parser_enabled and 'hexagon-linux-user' in
target_dirs
'idef_parser_input.preprocessed.h.inc',
output: 'idef_parser_input.preprocessed.h.inc',
input: idef_parser_input_generated,
- depend_files: [idef_parser_dir / 'macros.inc'],
+ depend_files: [idef_parser_dir / 'macros.h.inc'],
command: [idef_parser_dir / 'prepare', '@INPUT@', '-I' +
idef_parser_dir, '-o', '@OUTPUT@'],
)
--
2.39.5
- [PULL 06/22] hw/loongarch/virt: Add description for virt machine type, (continued)
- [PULL 06/22] hw/loongarch/virt: Add description for virt machine type, Michael Tokarev, 2024/09/20
- [PULL 07/22] tests/unit: Really build pbkdf test on macOS, Michael Tokarev, 2024/09/20
- [PULL 08/22] hw/virtio/Kconfig: Include vhost-user-scmi only on arm targets, Michael Tokarev, 2024/09/20
- [PULL 09/22] hw/display: Fix mirrored output in dm163, Michael Tokarev, 2024/09/20
- [PULL 10/22] envlist: Remove unused envlist_parse, Michael Tokarev, 2024/09/20
- [PULL 11/22] hw/sysbus: Remove unused sysbus_mmio_unmap, Michael Tokarev, 2024/09/20
- [PULL 13/22] tests/qemu-iotests/testenv: Use the "virt" machine for or1k, Michael Tokarev, 2024/09/20
- [PULL 12/22] util/cutils: Remove unused qemu_get_exec_dir, Michael Tokarev, 2024/09/20
- [PULL 14/22] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4/sh4eb, Michael Tokarev, 2024/09/20
- [PULL 15/22] tests/functional: Put the or1k_sim test into the slow category, Michael Tokarev, 2024/09/20
- [PULL 16/22] target/hexagon: Rename macros.inc -> macros.h.inc,
Michael Tokarev <=
- [PULL 17/22] tests/bench: Rename test_akcipher_keys.inc -> test_akcipher_keys.c.inc, Michael Tokarev, 2024/09/20
- [PULL 18/22] tests/functional: Correct typo in test_netdev_ethtool.py SPDX tag, Michael Tokarev, 2024/09/20
- [PULL 19/22] license: Simplify GPL-2.0-or-later license descriptions, Michael Tokarev, 2024/09/20
- [PULL 21/22] license: Update deprecated SPDX tag GPL-2.0+ to GPL-2.0-or-later, Michael Tokarev, 2024/09/20
- [PULL 20/22] license: Update deprecated SPDX tag LGPL-2.0+ to LGPL-2.0-or-later, Michael Tokarev, 2024/09/20
- [PULL 22/22] license: Update deprecated SPDX tag GPL-2.0 to GPL-2.0-only, Michael Tokarev, 2024/09/20
- Re: [PULL 00/22] Trivial patches for 2024-09-20, Peter Maydell, 2024/09/26