qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] hw: fix memory leak in IRQState allocation


From: Peter Maydell
Subject: Re: [PATCH v2] hw: fix memory leak in IRQState allocation
Date: Mon, 30 Sep 2024 17:08:38 +0100

On Wed, 18 Sept 2024 at 16:44, Matheus Tavares Bernardino
<quic_mathbern@quicinc.com> wrote:
>
> At e72a7f65c1 (hw: Move declaration of IRQState to header and add init
> function, 2024-06-29), we've changed qemu_allocate_irq() to use a
> combination of g_new() + object_initialize() instead of
> IRQ(object_new()). The latter sets obj->free, so that that the memory is
> properly cleaned when the object is finalized, but the former doesn't.
>
> Fixes: e72a7f65c1 (hw: Move declaration of IRQState to header and add init 
> function)
> Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> In v2: adjusted function init_irq_fields name to reflect it is not
> public and added BALATON's Reviewed-by

I'll pick this one up via target-arm.next, unless anybody
would prefer it to go via some other route.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]