qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/char: Remove unused serial_set_frequency


From: Thomas Huth
Subject: Re: [PATCH] hw/char: Remove unused serial_set_frequency
Date: Wed, 2 Oct 2024 12:31:48 +0200
User-agent: Mozilla Thunderbird

On 18/09/2024 16.41, dave@treblig.org wrote:
From: "Dr. David Alan Gilbert" <dave@treblig.org>

serial_set_frequnecy has been unused since it was added in 2009:
   038eaf82c8 ("serial: Add interface to set reference oscillator frequency")

It looks like the 'baudbase' is now a property anyway so the wrapper
isn't needed.

Remove it.

Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
  hw/char/serial.c         | 7 -------
  include/hw/char/serial.h | 2 --
  2 files changed, 9 deletions(-)

diff --git a/hw/char/serial.c b/hw/char/serial.c
index d8b2db5082..6c5c4a23c7 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -951,13 +951,6 @@ static void serial_unrealize(DeviceState *dev)
      qemu_unregister_reset(serial_reset, s);
  }
-/* Change the main reference oscillator frequency. */
-void serial_set_frequency(SerialState *s, uint32_t frequency)
-{
-    s->baudbase = frequency;
-    serial_update_parameters(s);
-}
-
  const MemoryRegionOps serial_io_ops = {
      .read = serial_ioport_read,
      .write = serial_ioport_write,
diff --git a/include/hw/char/serial.h b/include/hw/char/serial.h
index 6e14099ee7..40aad21df3 100644
--- a/include/hw/char/serial.h
+++ b/include/hw/char/serial.h
@@ -93,8 +93,6 @@ struct SerialMM {
  extern const VMStateDescription vmstate_serial;
  extern const MemoryRegionOps serial_io_ops;
-void serial_set_frequency(SerialState *s, uint32_t frequency);
-
  #define TYPE_SERIAL "serial"
  OBJECT_DECLARE_SIMPLE_TYPE(SerialState, SERIAL)

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]