qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/net/rocker: Remove unused rocker_fp_ports


From: Thomas Huth
Subject: Re: [PATCH] hw/net/rocker: Remove unused rocker_fp_ports
Date: Wed, 2 Oct 2024 12:43:08 +0200
User-agent: Mozilla Thunderbird

On 19/09/2024 01.14, dave@treblig.org wrote:
From: "Dr. David Alan Gilbert" <dave@treblig.org>

rocker_fp_ports hasn't been used since it was added back in 2015.
Remove it.

Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
  hw/net/rocker/rocker.c | 5 -----
  hw/net/rocker/rocker.h | 1 -
  2 files changed, 6 deletions(-)

diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c
index 1ab5852113..5e74acc969 100644
--- a/hw/net/rocker/rocker.c
+++ b/hw/net/rocker/rocker.c
@@ -134,11 +134,6 @@ RockerPortList *qmp_query_rocker_ports(const char *name, 
Error **errp)
      return list;
  }
-uint32_t rocker_fp_ports(Rocker *r)
-{
-    return r->fp_ports;
-}
-
  static uint32_t rocker_get_pport_by_tx_ring(Rocker *r,
                                              DescRing *ring)
  {
diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h
index f85354d9d1..6e0962f47a 100644
--- a/hw/net/rocker/rocker.h
+++ b/hw/net/rocker/rocker.h
@@ -72,7 +72,6 @@ DECLARE_INSTANCE_CHECKER(Rocker, ROCKER,
                           TYPE_ROCKER)
Rocker *rocker_find(const char *name);
-uint32_t rocker_fp_ports(Rocker *r);
  int rocker_event_link_changed(Rocker *r, uint32_t pport, bool link_up);
  int rocker_event_mac_vlan_seen(Rocker *r, uint32_t pport, uint8_t *addr,
                                 uint16_t vlan_id);

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]