Re: [PULL 10/23] linux-user: Remove unused handle_vm86_fault

[Michael Tokarev]

On 11.10.2024 19:02, Thomas Huth wrote:
> On 04/10/2024 18.03, Michael Tokarev wrote:
> > From: "Dr. David Alan Gilbert" <dave@treblig.org>
> >
> > handle_vm86_fault has been unused since:
> >    1ade5b2fed ("linux-user/i386: Split out maybe_handle_vm86_trap")
> >
> > Remove it, and it's local macros.

> FYI, looks like this broke compiling with Clang:
>
> ../../devel/qemu/linux-user/vm86.c:50:20: error: unused function 
> 'vm_putl' [-Werror,-Wunused-function]
>     50 | static inline void vm_putl(CPUX86State *env, uint32_t segptr,
>        |                    ^~~~~~~
> ../../devel/qemu/linux-user/vm86.c:56:28: error: unused function 
> 'vm_getb' [-Werror,-Wunused-function]
...

Hm. I built it with clang before sending the MR.
But it was clang16 - the most recent one on bookworm.  It
does not show this issue :)

Apparently I should upgrade clang somehow.

Thank you for the fix!

/mjt