Re: [Quilt-dev] [RFC][PATCH v2][QUILT] Add gpg signing to quilt mail

[Greg KH]

On Tue, Oct 04, 2011 at 02:15:46PM -0400, Steven Rostedt wrote:
> On Tue, 2011-10-04 at 11:02 -0700, Greg KH wrote:
> > Now if only someone can get quilt working properly for git's "split"
> >  subject: lines, I would be very happy...
> 
> What issues do you have? I use quilt to send git patches all the time.

The other way around, I import git patches into quilt for the stable
series, and then when sending emails out, quilt messes up the subject
lines because it was split across two lines.

> What are git's "split" subject: lines?

Do the following:
 $ git show --pretty=email 21d17dd2a377ba894f26989915eb3c6e427a3656

and look at how the Subject line is formatted:
        Subject: [PATCH] ASoC: Fix setting update bits for WM8753_LADC and
         WM8753_RADC

Which is legal for email subject lines.  But quilt can't handle this and
ends up thinking the data after the Subject: line is part of the patch
text body and messes stuff up when doing 'quilt mail' later.

So I have to remember to edit the subject: lines all the time, and
cringe when I forget.

Oh, then there's the issue of quilt not handling ',' in a Signed-off-by
line as a valid email address name, but I've been living with that one
for years...

thanks,

greg k-h