Re: [Quilt-dev] [PATCH 3/4] quilt mail: force locale to C when generating date for the From header

[Jean Delvare]

Hi Andreas,

On Friday 24 February 2012 08:03:18 am Andreas Gruenbacher wrote:
> On Fre, 2012-02-24 at 00:27 +0100, Raphaël Hertzog wrote:
> > From: Simon Horman <address@hidden>
> >
> > Without this the From header will end up with a date according
> > to the current locale, which can result in an invalid mbox.
> > That was at least the case with a japanese locale (ja_JP.UTF-8),
> > mutt-ng did not accept the mbox.
> >
> > Signed-off-by: Raphaël Hertzog <address@hidden>
> > ---
> >  quilt/mail.in |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/quilt/mail.in b/quilt/mail.in
> > index de23878..eacbe8d 100644
> > --- a/quilt/mail.in
> > +++ b/quilt/mail.in
> > @@ -141,7 +141,7 @@ process_mail()
> >
> >             | ${QUILT_SENDMAIL:-sendmail} \
> >
> >                     ${QUILT_SENDMAIL_ARGS--f "$opt_sender"} "$@"
> >     else
> > -           local from_date=$(date "+%a %b %e %H:%M:%S %Y")
> > +           local from_date=$(LC_ALL=C date "+%a %b %e %H:%M:%S %Y")
> >             echo "From $opt_sender_address $from_date"
> >             sed -e 's/^From />From /' $tmpfile
> >             echo
> 
> This is the same as commit "quilt mail: Don't use localized date
>  format in From lines" on the fixes-0.5 branch.
> 
> Jean, can you please pull this branch in as well?  Thanks.

I've just done that. This is the first time I merge branches using git 
so I hope I got it right. I used "quilt merge remote/fixes-0.51", then 
updated quilt.changes and configure, and pushed the result upstream. If 
I did anything wrong, please let me know quickly.

-- 
Jean Delvare
Suse L3