Re: [Radiusplugin-users] openvpn segfault when username contains space

[William Cooley]

Has anyone tried the patch posted here: 
http://lists.gnu.org/archive/html/radiusplugin-devel/2009-02/msg00000.html ?
I just had the same thing happen to me. A user tried to logon with a 
trailing space and openvpn crashed. The username does not contain a 
space in the radius database.

Does this patch also fix the original problem of this thread? Is there a 
better patch available?


Ralf Lübben wrote:
> This time I found the problem.
>
> At auth_user_pass_verify the commonname is not changed:
> "user1 test" stays "user1 test"
>
> but
>
> at client_connect the commonname is changed:
> "user1 test" becomes "user1_test"
>
> The plugin expects that the commonname isn't changed between both events. 
>
> I have to change this behavior in the future.
>
>
>
> Am Freitag 27 Februar 2009 16:04:23 schrieb William Cooley:
>   
> > I just found this post on the dev mailing list.
> > http://lists.gnu.org/archive/html/radiusplugin-devel/2009-02/msg00000.html
> > It's not clear if the username had the whitespace in the radius server
> > or if the crash occurred when someone  accidentally added a space.
> > I just tried adding a space before or after the username and openvpn did
> > not crash. So I'm guessing this occurred because the username had a
> > space in the radius database.
> >
> > William Cooley wrote:
> >     
> > > http://openvpn.net/index.php/documentation/manuals/openvpn-20x-manpage.ht
> > > ml
> > >
> > > and go to the "auth-user-pass-verify script method" section.
> > >
> > > Sorry I don't have a log file. (Openvpn resets it on restart) I had
> > > the server set to verb 4 and it still wasn't clear what the problem
> > > was. The plugin did not show any error messages.
> > > I finally figured it out because openvpn always crashed when this
> > > particular user attempted to connect. The openvpn log showed the
> > > username as having a _ not a space.
> > >
> > > Ralf Lübben wrote:
> > >       
> > > > Hi,
> > > >
> > > > someone else told me about a similiar problem, when the username
> > > > starts with a space. But I couldn't redo it.
> > > >
> > > > Can you send me a link where I find the information, that OpenVPN
> > > > changes characters?
> > > > Can you also send me a log file? Or tell me where the plugin crashes?
> > > >
> > > > Thanks.
> > > >
> > > > Ralf
> > > >
> > > > On Thursday 26 February 2009 22:57:39 William Cooley wrote:
> > > >         
> > > > > When an openvpn username contains a space openvpn segfaults and does
> > > > > not
> > > > > restart.
> > > > > Ubuntu 8.04 64bit
> > > > > Openvpn 2.1_rc7 and 2.0.9
> > > > > RadiusPlugin Version 2.0c
> > > > > Freeradius
> > > > > I have not tried to duplicate this bug with a different environment.
> > > > >
> > > > > I thought openvpn changes illegal characters to _ so maybe the _ caused
> > > > > the problem.
> > > > > I've simply disabled the use of non alphanumeric characters on new
> > > > > freeradius usernames to resolve this.
> > > > > -William
> > > > >
> > > > >
> > > > >
> > > > > _______________________________________________
> > > > > Radiusplugin-users mailing list
> > > > > address@hidden
> > > > > http://lists.nongnu.org/mailman/listinfo/radiusplugin-users
> > > > >           
> > > > _______________________________________________
> > > > Radiusplugin-users mailing list
> > > > address@hidden
> > > > http://lists.nongnu.org/mailman/listinfo/radiusplugin-users
> > > >         
> > > _______________________________________________
> > > Radiusplugin-users mailing list
> > > address@hidden
> > > http://lists.nongnu.org/mailman/listinfo/radiusplugin-users
> > >       
> > _______________________________________________
> > Radiusplugin-users mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/radiusplugin-users
> >     
>
>
>
> _______________________________________________
> Radiusplugin-users mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/radiusplugin-users
>