[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Rapp-dev] Pixelwise threshold and conditional pixel operations path
Re: [Rapp-dev] Pixelwise threshold and conditional pixel operations pathes
Thu, 19 May 2016 14:19:24 +0200
A 36 times improvement is impressive, thanks.
I'm looking at these and earlier patches right now. It'll take
a little longer than expected to weed out unnecessary
reformatting (only white-space changes) in existing code and
unnecessary inconsistencies in formatting (both regarding rules
and within the submitted code) in your patch. Those just make
it harder to spot typos and review the *intended* changes.
Please make sure to read and follow HACKING.
Your earlier rapp_validate_buffer submission will go in with
this, and we'll make a release in days after that. I'm on the
fence regarding including the vectorization of integral
functions submitted even before that; that'll probably be left
out at this time as it'll have to be cleaned up and ISTR the
performance improvement wasn't a priority.
Thanks also to Johan for the functional review.