[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

We need more Pull Requests reviewer

From: Eric L. Zolf
Subject: We need more Pull Requests reviewer
Date: Thu, 6 Aug 2020 07:46:31 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0


as the subject says, pull requests can stay for days without review, and
I really don't like merging my own PRs without someone having looked
over it.

Reviewing documentation doesn't require any specific knowledge even if
being a native English speaker might be an advantage :-) Just tell the
author if you understand what he wrote, and if the language is correct.

Reviewing code is more engaged but requires IMHO only some Python coding
knowledge and the ability to detect bad coding style, and challenge the
author to make sure nothing has been overlooked and everything is
properly commented. It doesn't require deep knowledge of the code but
can be a great way to gain this knowledge.

You only need to review the PR which are _not_ WIP and where the
pipeline job was successful (green tick).

Thanks, Eric

reply via email to

[Prev in Thread] Current Thread [Next in Thread]