[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cross-platform backup tool Lack of reviewers (again) and decision

From: Jonas Schöpf
Subject: Re: cross-platform backup tool Lack of reviewers (again) and decision
Date: Sun, 28 Nov 2021 17:42:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2

Hi Eric!

First of all, thank you for all the work you put into rdiff-backup! I love this tool!

Last time you wrote an email about lack of reviewers, I took a look at the PRs, but couldn't decide anything about them as I lack knowledge of the implementation.

I "watch" the repo now and try to find some time to look at the code such that in the future I might be somehow more helpful for this project :)


On 11/10/21 06:50, Eric L. Zolf wrote:

I don't want to sound like a broken record but I have again a pull
request [1] waiting for review and nobody takes care.

Our contribution guide states that "Ideally each pull request gets some
feedback within 24 hours from it having been filed" and we're far from
it. I'm also tired of begging for review.

For this reason, I'll stop begging and will merge my own PRs after a
little while (24h-48h, perhaps more if the PR isn't blocking me). Not
exactly development best practice, but anybody disagreeing is free to
commit to provide timely feedback to PRs, and I'll happily support them
in this endeavor.

Thanks for your attention, Eric

[1] https://github.com/rdiff-backup/rdiff-backup/pull/632

reply via email to

[Prev in Thread] Current Thread [Next in Thread]