[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Savannah-hackers-public] Re: log_accum at Savannah

From: Sylvain Beucler
Subject: [Savannah-hackers-public] Re: log_accum at Savannah
Date: Tue, 6 Jun 2006 00:04:43 +0200
User-agent: Mutt/1.5.11+cvs20060403

> > Ok. Maybe it would ease the job if we only accept -S and -S=mail ?
> >
> > I don't know if GetOpt supports this though.
> >   
> I don't think so.  It can be prevented from allowing =, but not limited
> to it, on my last reading.  I'd just as soon leave it as it is, unless
> you have a strong objection to the syntax.

If that's more simple that way, no problem :)

> >> If --separate-diffs is specified without any email addresses, diffs will
> >> be mailed to the --mail-to address(es).
> >>     
> >
> > Ok. Currently nobody uses this at Savannah though.
> >   
> Nobody uses --separate-diffs, or no one uses --separate-diffs sent to
> the --mail-to addresses?

The latter - do you believe I'd be nasty enough to let you port a
feature that is actually completely useless? ;)

> > Also, you removed the text output stating that a notification was
> > sent. I find it useful, because users can see that the notification
> > was sent - even if they don't get the mail for some reason. Was it
> > intentionnal? Currently I added an "echo" command in loginfo, but it
> > is not as accurate as using it directly in log_accum. Would that be
> > ok?
> >   
> Removing the message was completely unintentional.  I restored something
> similar except it prints "sent." at the end, only when successful.  I
> also added a similar line summarizing the diff status.  Is this acceptable?

Perfect. I installed it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]