savannah-hackers-public
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Savannah-hackers-public] git-to-cvs for coreutils


From: Jim Meyering
Subject: Re: [Savannah-hackers-public] git-to-cvs for coreutils
Date: Mon, 08 Jan 2007 14:39:19 +0100

Sylvain Beucler <address@hidden> wrote:
...
> Or, you can volunteer
> for keeping on eye on this program and upgrade it on a regular basis,
> and document its existence in the infra/git.txt documentation :)

That's a good compromise.
I've just added comments to that effect in that file.

>> > without a security track. Feel free to install software but setup
>> > security/updates alongside :)
>> >
>> > - I try to imagine how this could then be automated. I'm thinking of
>> > something smilar to CVS commitinfo/loginfo: 'update' would then be a
>> > wrapper script generated by Savane, calling your unmodified script
>> > with command line arguments. It would be good then to be able to
>> > control your script with command line arguments instead of using a
>> > modified version of the script for each project.
>> >
>> > - I'm not sure address@hidden is a valid adress, there's no smtp
>> > service for receiving mail at SV. I don't understand the issue with
>> > mails "From: address@hidden", can you explain me?
>>
>> I can change it to something else, if you'd like, but the default
>> is unusable.
>>
>> The "mail" program is not usable without -a 'From ...' because when
>> sending mail to my address, it uses that same address in the From_ header.
>> That would cause my mail system (or any reasonably strict anti-spam setup)
>> to smtp-reject it as a forgery, since it is claiming to be from my domain
>> (meyering.net), while actually coming from sv.gnu.org.
>>
>> I've just fixed the update hook to work properly:
>>
>>         * /srv/git/coreutils.git/hooks/update: Use "mail -a 'From ...',
>>         not "mail -a 'From: ...'.
>
> Ok (currently this is indeed not addressed with e.g. the CVS commit
> hooks).  I wonder if it wouldn't make sense to accept sv.gnu.org as a
> valid sender for meyering.net - since SV is kinda proxying a mail
> request from you in this context. Oh well.

It doesn't seem like a proxy for meyering.net to me.  Somehow (this
seems like a bug, but I can't reproduce it from the command line)
without the -a, mail(1) uses the recipient address as the From_ one.
So, if someone were to use this set-up for another project, and to put
their address in the script in place of mine, they'd encounter the same
problem, but for their domain.

> address@hidden can be used as a valid (and :blackhole) sender
> adress I think.

Thanks.  The hook script now uses that.

> Btw please update the wiki some of this is interesting.

Where?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]