[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Savannah-hackers-public] exact search code proposal

From: Sylvain Beucler
Subject: Re: [Savannah-hackers-public] exact search code proposal
Date: Mon, 28 Apr 2008 20:19:25 +0200
User-agent: Mutt/1.5.17+20080114 (2008-01-14)


On Mon, Apr 28, 2008 at 10:27:30AM -0700, nick alvaro wrote:
> function search_send_header was causing me some issues so I had to
> change it. I called for the search_exact function in the
> search_send_header function's "if ($type_of_search == "soft")"
> expression and moved each "<h3>" to each $type_of_search expression
> as well. This is because the exact search result has to come after
> the header is called and after the Search Criteria box is called but
> before the heading 3 is printed out.
> Here are my proposed changes:

At first glance it looks good.
I have a few technical suggestions:

- Use db_execute for database access. It is similar to AdoDB's
  Execute function, and does a secure escaping for PHP variables
  included in the query.

- Can you send your changes as a patch? You could use 'git diff' for
  instance. It's easier to review changes that way.

- You could use a JOIN to perform only one query instead of two :)

> ____________________________________________________________________________________
> Be a better friend, newshound, and 
> know-it-all with Yahoo! Mobile.  Try it now.  

Sure, but this pretty off-topic, don't you think? :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]