[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Savannah-hackers-public] bzr post-commit email hook

From: Bob Proulx
Subject: Re: [Savannah-hackers-public] bzr post-commit email hook
Date: Sat, 11 Feb 2017 00:56:31 -0700
User-agent: NeoMutt/20170113 (1.7.2)

Glenn Morris wrote:
> Bob Proulx wrote:
> > Yes.  Looks like bzr is logging to /var/lib/bzr/bzr-anon.log.  Which I
> > think should be /var/log/bzr/bzr-anon.log instead.  I am going to make
> > that change.  Will copy the logrotate over for the new location.
> It's as you prefer. But you will need to edit
> /opt/savannah/bin/sv_membersh as well, for the non-anonymous log.

I moved the log file for both of those to /var/log.  I modified
/etc/logrotate.d/bzr for the new location.  I shorted the logging save
time because there is a big push via rms to avoid logging data.

> >> Other relevant stuff I did from the old ChangeLog on mgt:
> >> 
> >>       * [vcs]: `apt-get install locales'.  Generate only en_US.utf8,
> >>       and en_US.ISO8859-1, leave system default as none (ie leave
> >>       /etc/default/locale empty).
> >
> > Why en_US.ISO8859-1 and not en_US.UTF-8 as en_US.UTF-8 has become the
> > standard these days?  Of course any admin using a different locale is
> > free to set up one that is useful to them.  But by default only
> > en_US.UTF-8 was set up on the new servers.
> en_US.ISO8859-1 is what bzr needed, because Savannah gecos information
> was stored in latin-1. See my comment in sv_membersh and the cited thread
> .

Ouch!  Thanks for the information on that.

Seems that en_US.ISO-8859-1 is available.  Someone else got to it first.

address@hidden:~# dpkg-reconfigure locales
Generating locales...
  en_AG.UTF-8... done
  en_AU.UTF-8... done
  en_BW.UTF-8... done
  en_CA.UTF-8... done
  en_DK.UTF-8... done
  en_GB.UTF-8... done
  en_HK.UTF-8... done
  en_IE.UTF-8... done
  en_IN.UTF-8... done
  en_NG.UTF-8... done
  en_NZ.UTF-8... done
  en_PH.UTF-8... done
  en_SG.UTF-8... done
  en_US.ISO-8859-1... up-to-date
  en_US.UTF-8... up-to-date
  en_ZA.UTF-8... done
  en_ZM.UTF-8... done
  en_ZW.UTF-8... done
Generation complete.

> If Savannah gecos has since changed to utf-8, then the bzr LANG line in
> sv_membersh could be changed or removed.

I don't think there has been any change.  But that seems like a good
improvement.  It would need to be made in the PHP that stores the
information into the database.  If/When that is changed then it would
flow through as UTF-8.  We could use iconv on the existing data and
migrate it in place.  A good task for some time in the future.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]