[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Savannah-hackers-public] Patch for savannah frontend

From: Bob Proulx
Subject: Re: [Savannah-hackers-public] Patch for savannah frontend
Date: Thu, 26 Apr 2018 22:45:57 -0600
User-agent: Mutt/1.9.5 (2018-04-13)

Hello Lukas,

Lukas Diener wrote:
> As per the HowToBecomeASavannahHacker wiki page, I would like to 
> introduce myself a bit to be able to contribute a small patch to the 
> savannah project.

Thank you for contributing! :-)

> My name is Lukas, I'm a programmer and teacher from Switzerland. I don't 
> have much of a background with free software other than using the usual 
> mainstream software (bash, GIMP, Gzip, Wget). I did attend a talk of Mr. 
> Stallman at the University of Berne, Switzerland about 2 years ago 
> though. My savannah username is Lukas_Skywalker.

Pleased to meet you.

> Regarding the patch: the search box in the left naviational menu of 
> savannah was overflowing the menu bar on Firefox. This attached patch 
> fixes that.

Thank you very much for seeing this problem and contributing a patch.
I do not see this overflow in my Firefox ESR 52 or Chromium 64.  Could
you say what version of Firefox you are using?  Or does it only
overflow with specific viewport sizes?  How can I recreate the problem?

The modification seems reasonable however.  I have installed it into
the production server.  It's running now.  I have not committed the
change to version control yet giving time for a few others to test the
change (since I cannot verify it) and to give you a chance to verify
that this fixes the problem you are seeing.  Does it?

I very slightly modified the patch to maintain the same indention as
the other lines in the file.  Generally when making modifications one
always maintains the same indention style as the rest of the file even
if it isn't the indentation one normally prefers and uses.

The modification is small (around 15 lines or so is the legal limit)
and does not need a copyright assignment.

If things look okay to you as running now then I will make the
following commit.

    Fix overflow of left navigation menu search box.
    Problem reported by and fix submitted by Lukas Diener.

diff --git a/frontend/php/css/internal/base.css 
index e720de6..bfaaf7d 100644
--- a/frontend/php/css/internal/base.css
+++ b/frontend/php/css/internal/base.css
@@ -416,6 +416,11 @@ h5 a {
        font-size: smaller;
+.menusearch input[name=words] {
+       width: 100%;
+       box-sizing: border-box;
 .relatedrecipes {
        text-indent: 0;
        list-style-type: none;

THANK YOU for your contribution!  If you see more problems please
contribute more fixes!  :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]