[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Savannah-help-public] commit mail notification for inetutils.git
From: |
Sylvain Beucler |
Subject: |
Re: [Savannah-help-public] commit mail notification for inetutils.git |
Date: |
Tue, 17 Nov 2009 22:24:25 +0100 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Tue, Nov 17, 2009 at 10:14:56PM +0100, Jim Meyering wrote:
> Sylvain Beucler wrote:
>
> > I updated inetutils.git to use the current git mail notification
> > script (as documented in git.txt).
> >
> > Here it seems that Alfred pushes 3 commits:
> >
> > http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=e7440293e6eb3bd478fb098a88e13049fda409d6
> >
> > http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=f3fb446b2c0066ebc6a46fda6dc22db7f4905b79
> >
> > http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=580a9e8db4453305c75ae20435da3a09d74d2104
> > but got 3x the latest diff.
>
> Hi Sylvain,
>
> I suspect that the config setting is wrong.
> It's admittedly quite tricky, considering all of the different
> types of quoting involved. Currently inetutils has this:
>
> hooks.showrev=echo
> http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=%s; echo; echo; git
> show -C %s; echo
>
> Try this, based on what I did here:
> http://sourceware.org/ml/libc-ports/2009-05/msg00045.html
>
> hooks.showrev=t=%s; printf
> 'http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=%%s' $t; echo;
> echo; git show -C $t; echo
>
> Here's the relevant comment in that file (at least in upstream git.git):
>
> # message. To list full patches separated by a blank line, you
> # could set this to "git show -C %s; echo".
> +# To list a gitweb/cgit URL *and* a full patch for each change set, use
> this:
> +# "t=%s; printf 'http://.../?id=%%s' \$t; echo;echo; git show -C \$t;
> echo"
> +# Be careful if "..." contains things that will be expanded by shell "eval"
> +# or printf.
Indeed, this %s is expanded only once. Ugh...
Gonna fix this.
Thanks!
--
Sylvain