[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [screen-devel] [PATCH 0/1] add compat layer to handle both fifos and

From: Amadeusz Sławiński
Subject: Re: [screen-devel] [PATCH 0/1] add compat layer to handle both fifos and sockets
Date: Tue, 11 Apr 2017 11:31:52 +0200

On Mon, 10 Apr 2017 21:33:14 +0200
Christian Brauner <address@hidden> wrote:

> The code uses kernel-style and it seems this is what screen master is
> also aiming at.


yes... but it makes it hard to review patch if you change code style while
adding other changes. Can you resend without changing format.
(On master all source code was reformatted in separate commit)

One thing I wonder in particular is wouldn't it make everythink simpler
to leave MakeClientSocket call declaration as it is and move socket check
inside, but would like to get a better look at patch with less churn.

Somethink like:

int MakeClientSocket(int err)
        bool socket;

        socket = IsSocket(SockPath);

       if (socket)
               return MakeClientUnixSocket(err);

       return MakeClientFifo(err);


reply via email to

[Prev in Thread] Current Thread [Next in Thread]