screen-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[screen-devel] [PATCH 5/6] Fix possible unterminated string


From: Václav Doležal
Subject: [screen-devel] [PATCH 5/6] Fix possible unterminated string
Date: Wed, 7 Nov 2018 16:10:33 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

Signed-off-by: Vaclav Dolezal <address@hidden>
---
 src/pty.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/pty.c b/src/pty.c
index 1c0660e..eba3bb0 100644
--- a/src/pty.c
+++ b/src/pty.c
@@ -279,7 +279,13 @@ char **ttyn;
       return -1;
     }
   signal(SIGCHLD, sigcld);
-  strncpy(TtyName, m, sizeof(TtyName));
+  if (strlen(m) < sizeof(TtyName))
+    strcpy(TtyName, m);
+  else
+    {
+      close(f);
+      return -1;
+    }
   initmaster(f);
   *ttyn = TtyName;
   return f;
-- 
2.14.5





reply via email to

[Prev in Thread] Current Thread [Next in Thread]