Re: Trouble with hardstatus under 5.0.0

[Christian Kujau]

On Fri, 30 Aug 2024, Christian Kujau wrote:
> This will take a while to bisect:

OTOH, git-bisect really *is* an awesome tool:

$ git bisect bad
99a8b26d7ae221dfdc1bbe8f04f5867f7ebc07bc is the first bad commit
commit 99a8b26d7ae221dfdc1bbe8f04f5867f7ebc07bc
Author: Amadeusz Sławiński <amade@asmblr.net>
Date:   Sat Jan 12 23:01:42 2013 +0100

    Remove escape codes which can be handled by external scripts
    
    removes loadavg and time/date escape codes

 src/Makefile.in  |   6 +--
 src/configure.ac | 138 -------------------------------------------------------
 src/extern.h     |   6 ---
 src/loadav.c     | 103 -----------------------------------------
 src/screen.c     |  97 --------------------------------------
 5 files changed, 2 insertions(+), 348 deletions(-)
 delete mode 100644 src/loadav.c


The full git-bisect log can be found below; a few "bisect skip" calls were 
needed until I figured out the s/RC_KILL/CKILL/ in src/list_window.c. 

Christian.


git bisect start
# status: waiting for both good and bad commits
# good: [8a4124d5dee8d3399ac857c34364ac193b6add17] Release v.4.9.1
git bisect good 8a4124d5dee8d3399ac857c34364ac193b6add17
# status: waiting for bad commit, 1 good commit known
# bad: [9d8b0ff3901bdcb8d3bc05d94fce2ef987562768] Release v.5.0.0
git bisect bad 9d8b0ff3901bdcb8d3bc05d94fce2ef987562768
# good: [6df6baeeb193d5858e811ed5a281d1cd19bc26ab] Fix OpenBSD build
git bisect good 6df6baeeb193d5858e811ed5a281d1cd19bc26ab
# bad: [80206032901cf11a2cb4392caaf2ee48ca82a273] reindent layer.c
git bisect bad 80206032901cf11a2cb4392caaf2ee48ca82a273
# skip: [511e38840f1653dd6e71eba90271756d4b2af03d] use Viewport type instead of 
struct viewport
git bisect skip 511e38840f1653dd6e71eba90271756d4b2af03d
# skip: [7d7268ccb67c3cb0eda5a795f39fc2507c734c1e] forward declarations for 
types make more sense in a separate file
git bisect skip 7d7268ccb67c3cb0eda5a795f39fc2507c734c1e
# good: [5e487cefc87782b0c95876277d826db2cec28a43] Use mode_t type
git bisect good 5e487cefc87782b0c95876277d826db2cec28a43
# skip: [0159985b3000dbae77dc8302bb9dbc033d0e7a2e] WinMsgBuf buffer is now 
dynamically allocated
git bisect skip 0159985b3000dbae77dc8302bb9dbc033d0e7a2e
# skip: [c78ea7a19d77f009d3a96553d5188a55e6b020cc] Began refactoring 
conditional escapes %? and %: to use WinMsgCond abstraction
git bisect skip c78ea7a19d77f009d3a96553d5188a55e6b020cc
# bad: [eafa84cc735a73c2d07ff5eaa719c228e9cc864a] Dereference of null pointer
git bisect bad eafa84cc735a73c2d07ff5eaa719c228e9cc864a
# skip: [995552f6a941bda5b66732829ba3f5a513e22e9a] silence some warnings
git bisect skip 995552f6a941bda5b66732829ba3f5a513e22e9a
# skip: [f320dfd117339aa5d3d6b118b4a606c16dba8e22] wmb{,c}_create modified to 
return NULL instead of invoking Panic
git bisect skip f320dfd117339aa5d3d6b118b4a606c16dba8e22
# bad: [a73a91ea68bb6230a354990689dd58fff5153cac] get rid of extern.h
git bisect bad a73a91ea68bb6230a354990689dd58fff5153cac
# bad: [a73a91ea68bb6230a354990689dd58fff5153cac] get rid of extern.h
git bisect bad a73a91ea68bb6230a354990689dd58fff5153cac
# bad: [23eaac6763a1a0a9f837d094bfb5f13d0cf25a44] add basic multiwindow input 
support
git bisect bad 23eaac6763a1a0a9f837d094bfb5f13d0cf25a44
# bad: [23eaac6763a1a0a9f837d094bfb5f13d0cf25a44] add basic multiwindow input 
support
git bisect bad 23eaac6763a1a0a9f837d094bfb5f13d0cf25a44
# good: [f664527d166a5bb5b62ccd14cde19bc1f301a7b7] POSIX: just use setenv
git bisect good f664527d166a5bb5b62ccd14cde19bc1f301a7b7
# bad: [0f63134ea1ba030c1ffdc2e5c550f2d5a8c06e14] fix implicit utime declaration
git bisect bad 0f63134ea1ba030c1ffdc2e5c550f2d5a8c06e14
# good: [2b4641c1416e08c384e808e27008def40964b099] change struct mchar to use 
uint32_t instead of chars
git bisect good 2b4641c1416e08c384e808e27008def40964b099
# bad: [52400b81cfe7fd875251bc80a5b60d9af930b2ac] add -Wextra and -std=c1x to 
CFLAGS
git bisect bad 52400b81cfe7fd875251bc80a5b60d9af930b2ac
# good: [d95ad5452fff7e3f4500ce9759756d69f0064986] remove attrcolor, some more 
color handling stuff
git bisect good d95ad5452fff7e3f4500ce9759756d69f0064986
# bad: [99a8b26d7ae221dfdc1bbe8f04f5867f7ebc07bc] Remove escape codes which can 
be handled by external scripts
git bisect bad 99a8b26d7ae221dfdc1bbe8f04f5867f7ebc07bc
# first bad commit: [99a8b26d7ae221dfdc1bbe8f04f5867f7ebc07bc] Remove escape 
codes which can be handled by external scripts 

-- 
BOFH excuse #10:

hardware stress fractures