[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] doc: fix copy-pasted examples of regexp

From: Assaf Gordon
Subject: Re: [PATCH 1/4] doc: fix copy-pasted examples of regexp
Date: Tue, 7 Feb 2017 04:56:21 -0500

Hello Alexandre,

Thank you for these patches.

> On Feb 3, 2017, at 19:36, Alexandre Jasmin <address@hidden> wrote:

> [PATCH 1/4] doc: fix copy-pasted examples of regexp

Pushed here:

> [PATCH 2/4] doc: rework BRE/ERE table to fit PDF manual

Will need a bit more review, hope to have this soon.

> [PATCH 3/4] doc: change description of the r command

Pushed here:

> [PATCH 4/4] doc: reference the i command in /regexp/I

Here I would suggest not using @ref as an embedded word.
texinfo renders it nicely in HTML (making it an <a> tag),
but in PDF it will look strange:
"However, in sed the i is used for the (see [insert command], page 13)."

Attached is a slight modification to your patch, comments welcomed.

Attachment: 0001-doc-reference-the-i-command-in-regexp-I.patch
Description: Binary data

Contribution to GNU packages over a certain size (typically 10-ish lines) 
require copyright
assignment. Since your patches are smaller than that, and only touch the 
they can be waived (hence the added "copyright exempt" lines added at the bottom
of the commit messages).

However if you plan to send more patches (which we very much encourage!),
please fill out the copyright assignment form:
and send a signed copy of it to address@hidden .

To learn more about copyright assignment, see here:

 - assaf

reply via email to

[Prev in Thread] Current Thread [Next in Thread]