[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Suggestion: tests: refactor tests to new shell scripts

From: Jim Meyering
Subject: Re: Suggestion: tests: refactor tests to new shell scripts
Date: Mon, 10 Apr 2017 08:32:00 -0700

On Sun, Apr 9, 2017 at 9:44 PM, Assaf Gordon <address@hidden> wrote:
> Hello,
>> On Apr 8, 2017, at 11:44, Jim Meyering <address@hidden> wrote:
>> What do you think about using the perl-based framework for any test
>> whose program, input and output are best-suited or sufficiently small?
> Attached a patch with more tests converted to perl-style (this file includes 
> everything
> starting with your patch).
> It also includes two minor fixes:
>    maint: fix wrong PATH in testsuite
>    tests: fix new 'empty' perl test
> And a minor improvement to the perl infrastructure:
>    tests: keep temporary directory if SAVE_TEMPS requested

Nice work. Thanks a lot for reviewing my work and following through on this.

I applied it and ran "make check" which showed this:

LC_ALL=C  ./sed/sed --quiet -f ./testsuite/cv-vars.sed \
        < ./testsuite/cv-vars.inp | LC_ALL=C ./sed/sed 's/\r//g' > quiet.out
/bin/sh: ./testsuite/cv-vars.inp: No such file or directory
cmp ./testsuite/cv-vars.good quiet.out
cmp: ./testsuite/cv-vars.good: No such file or directory

No big deal. Just means that the "quiet" test also uses the
now-removed cv-vars files.

Thanks also for fixing my bugs. In your "maint: fix wrong PATH in
testsuite", the log has a typo: s/independantly/independently/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]