[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Suggestion: tests: refactor tests to new shell scripts

From: Jim Meyering
Subject: Re: Suggestion: tests: refactor tests to new shell scripts
Date: Sat, 6 May 2017 14:48:37 -0700

On Tue, May 2, 2017 at 12:25 AM, Jim Meyering <address@hidden> wrote:
> On Sat, Apr 29, 2017 at 9:49 AM, Assaf Gordon <address@hidden> wrote:
>> Hello Jim,
>> On Thu, Apr 27, 2017 at 06:03:10PM +0900, Jim Meyering wrote:
>>> nit so far:
>>> "make distcheck" fails with this:
>> Good catch. fixed.
>> Also the attached patch completes the conversion of all the tests,
>> and removes 'Makefile.tests' completely.
>> There are surely some odds and ends to fix, but generally it's working.
>> comments welcomed,
> Hi Assaf,
> Thank you for all of that work.
> I verified that "make distcheck" passes on an F25 system, but have not
> reviewed all of those changes. However, I suggest that you go ahead
> and push them. I'm returning from a vacation and so will have less
> time than normal in the next few days.

I looked a little more and ran "misspellings" on all of sed's
version-controlled files. It reported these:

testsuite/ preceeded -> "preceded"
testsuite/BOOST.tests:96: repetion -> "repetition"
testsuite/ addres -> "adders","address"
testsuite/ referencs -> "references"
testsuite/runptests.c:84: suceeds -> "succeeds"
testsuite/runtests.c:82: successfull -> "successful"
testsuite/tst-pcre.c:188: preceeding -> "preceding"
testsuite/uniq.good:310: UPTO -> "Up to"
testsuite/uniq.inp:813: UPTO -> "Up to"
testsuite/ expeced -> "expected"
testsuite/ expeced -> "expected"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]