[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fw: usage of local sed version in Makefile

From: Jim Meyering
Subject: Re: Fw: usage of local sed version in Makefile
Date: Tue, 14 Aug 2018 13:24:44 +0200

On Mon, Aug 13, 2018 at 1:19 AM Assaf Gordon <address@hidden> wrote:
> On Fri, Aug 10, 2018 at 06:13:05PM -0600, Assaf Gordon wrote:
> > > ----- Forwarded message from project-repo <address@hidden> -----
> > >
> > > I was wondering if there is a reason as to why the Makefile attempts to
> > > use the local sed built in the current directory before trying to use
> > > the installed sed version.
> >
> > I noticed the same annoying thing.
> >
> The attached patch should fix the issue.

Hi Assaf,
My main reservation is that the proposed patch would decrease sed test coverage.

It also adds a requirement that every build-related use of sed be
portable to every target system's vendor sed.

As the proposed-deleted comment suggests, I added that code after a
grep infloop bug that would have been avoided if syntax-check's uses
of grep exercised GNU grep's just-built binary.

If the primary goal is to avoid attempting to use a malfunctioning or
debug-enabled sed in build (not check-) related rules, an alternative
is to set PATH only if the build target is something "check"-related,
along the lines of GNUmakefile's _have-git-version-gen definition.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]