a new module in speech-dispatcher

[Olivier BERT]

On Thu, Jun 29, 2006 at 01:47:26PM +0200, Hynek Hanke wrote:
> Hi Olivier,
> 
> this is great news. I've reviewed the code, it looks very good. I have
> these concerns:
> 
> * The copyright statement doesn't contain the proper copyright
> attribution (Copyright (C) ...., date). If you do not object,
> I'd prefer copyright by Brailcom, o.p.s. This puts the whole project
> in a better legal position against possible violators.
No problem, I fixed it.

> 
> * line 136, module_init() contains the statement 'Debug = 1' which
> seems to do nothing. Delete?

I just removed it. It was there to enable debug logging. I didn't know 
that it could be done in the configuration file of the module. 

> 
> * Do we really need cicero_wrapper? I think we could just open a logfile
> in the driver and redirect the stderr of the subprocess there before we
> exec it. This way, we can do without installing an additional program.
> The file where logs from cicero should be stored of course would be
> configurable through cicero.conf.
Yes, of course, it would be better. I will fix it in a next commit. 

> 
> * line 218, module_speak() reads `char temp[500];' That sounds pretty
> dangerous.
> 
I don't know how I could write such a thing :). 
I fixed it. 


> * Do you plan to add support for voice and pitch change in the future?
For the moment, Cicero doesn't support change of pitch and volume at 
runtime even if it seems easy to implement it. 
I already suggested that to the author. I hope it will be 
possible soon. But the author of cicero seems very busy.


> * Also, would it theoretically be possible to return audio data from
> cicero and play them in the module or upstream? I do not think we should
> do that now as we are currently porting the modules from Dispatcher
> under TTS API and this audio handling part will change. But for the
> future, this approach would be better, so I'm curious.

I don't know. Maybe it could be asked to Nicolas Pitre (author of 
cicero). 

> Thanks for all your work!
> Hynek

Thanks very much.
> 
> PS: Please CC address@hidden .
Regards,

-- 
Olivier BERT
e-mail: address@hidden
Etudiant a l'E.P.I.T.A. (cycle ingenieur, 3eme annee)
Tel: 06 07 69 79 71
_______________________________________________
Speechd mailing list
address@hidden
http://lists.freebsoft.org/mailman/listinfo/speechd