[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] server - Only check for $HOME/.speech-dispatcher if the current
From: |
Luke Yelavich |
Subject: |
[PATCH] server - Only check for $HOME/.speech-dispatcher if the current user's home directory starts with /home |
Date: |
Mon, 31 Aug 2009 12:50:56 +1000 |
On Fri, Aug 28, 2009 at 08:19:56PM EST, Milan Zamazal wrote:
> >>>>> "LY" == Luke Yelavich <themuso at ubuntu.com> writes:
>
> LY> If the current user's home directory does not start with /home,
> LY> then it is safe to assume that speech-dispatcher is being run as
> LY> root, or another system user,
>
> It is not, home directories can be mount on another location. A better
> test on Debian systems with default adduser configuration would be
> checking uid, but this may be of no use on other systems.
>
> But the main question is why a system user should have
> ~/.speech-dispatcher/ present when it is going to be ignored? Isn't the
> ~/.speech-dispatcher/ presence check enough?
Right, misread things, and agree the approach is not the best, so the patch can
be disregarded.
Luke