[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

to attach, or not to attach?

From: Luke Yelavich
Subject: to attach, or not to attach?
Date: Mon, 15 Feb 2010 07:58:44 +1100

On Sun, Feb 14, 2010 at 11:09:28PM EST, Chris Brannon wrote:
> Halim Sahin wrote:
> > Hi,
> > Thx for you work but please can you send the patches as attachmnent?
> I basicly concur with William on this issue,
> for the following three reasons.
> 1. Inline patches are easier to review.
> 2. They are customary in many git-using email-based communities, notably
> the Linux Kernel Mailing List.
> 3. By default, git format-patch gives inline patches.
> Three is likely a corollary of two.
> There is one good counter-argument against inlining.
> If some list members are using a version control system other than git, then
> they will have an easier time with attachments.

I personally agree. I simply need to save the patch emails to a patches box, 
and run git am over that box.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]