[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Question with $PLAY_COMMAND
From: |
Steve Holmes |
Subject: |
Question with $PLAY_COMMAND |
Date: |
Fri, 5 Mar 2010 06:19:12 -0700 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
On Fri, Mar 05, 2010 at 06:38:56AM -0600, Chris Brannon wrote:
> Well, it turns out that there is a problem with the code that chooses
> play_command. I totally missed it yesterday!
> Here is src/modules/generic.c, line 396:
>
> }else{
> assert("Unknown audio output method requested");
> }
>
> The assert call aborts the program if a condition is false.
> In this case, the condition of the assert is just a string, and that's
> always true, under C's definition of truth. The process doesn't terminate
> when it decides that your audio output method is unknown.
>
> I'm going to send a patch for this one, later.
> One approach is to default to "play" for play_command.
> I think that the play program is commonly available.
> It should be a reasonable default.
> The other option is to print a warning and call abort. That seems to be
> the intent of the original code.
Well, I found what I think might be another bug. When I looked in my
speechd.conf more closely, I found the default audiooutput method was
commented out though the default is aclaimed to be SLSA. When I
uncommented this line and restarted speechd, it worked fine the first
time. So I don't think speechd is honoring it's default
AudioOutputMethod.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEAREDAAYFAkuRBNAACgkQWSjv55S0LfHQUgCcDS/YMg1uudW9DOkoZ5ttMXM8
fhUAnR+GOu03+xhupTJCukicGTxYcACX
=oYW/
-----END PGP SIGNATURE-----