[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] create a library of common routines

From: Hynek Hanke
Subject: [PATCH] create a library of common routines
Date: Tue, 03 Aug 2010 11:07:42 +0200

On 2.8.2010 22:25, William Hubbs wrote:
> This moves intl/ to src/common and turns that directory into a library
> of common routines

Hello Wiliam,

this is a useful improvement. We will use this as part of the code
cleanup and reorganization in the 0.8 release. I'm sending a few
small comments bellow which I would like to see addressed before
I create a new 0.8 branch and we apply this patch:

1) TFDSetElement, TFDSetClientSpecific, SPDMsgSettings and
str2intpriority is specific to the server and should not be moved
to src/common/ but somewhere to src/server/.

2) The new file in src/common/ should be called better than fdset.h .
It is currently called so for historical reasons, but when we move the
contents, it is a good opportunity to rename it to something
more fitting.

3) We should also remove the def.h file totally. It is now of little use.
Server configuration defaults should be centralized in config.c or config.h
along the other configuration options. Client libraries should do the right
thing on their own based on the documentation.

4) Then we could also get rid of the intl/ directory. This convention
is somehow confusing between 'internal' and 'internationalization',
not widely used and src/common/ is a better name.

Thank you and Best regards,
Hynek Hanke

reply via email to

[Prev in Thread] Current Thread [Next in Thread]