[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] return status from set_data_mode

From: Jon
Subject: [PATCH 1/2] return status from set_data_mode
Date: Fri, 6 Aug 2010 23:26:31 +0100


The send_command has a return statement, which is fine, since everything 
that is sent has a response code. For Orca we dont care so much if the 
rate/pitch/whatever changed, as requested, but it would be nice if they 
did. But more critically, I needed the return for the set_data_mode to 
know if it was safe to start sending ssml marked up text or not.


On Fri 06/08/2010 at 17:13:21, Chris Brannon wrote:
> > return the value of self._conn.send_command() in set_data_mode()
> > This change is based on a patch to opentts by Mesar Hameed to allow clients 
> > t
> > o see if the
> > data mode has been successfully set.
> +1 on both of these.
> Most (possibly all) of the set_* methods of SSIPClient don't return anything.
> They just call send_command, ignoring its return value.
> Should they return something?  If so, what should it be?
> -- Chris
> _______________________________________________
> Speechd mailing list
> Speechd at lists.freebsoft.org
> http://lists.freebsoft.org/mailman/listinfo/speechd

reply via email to

[Prev in Thread] Current Thread [Next in Thread]