[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

State of the 0.7.1 release

From: Hynek Hanke
Subject: State of the 0.7.1 release
Date: Wed, 11 Aug 2010 11:47:13 +0200

On 10.8.2010 17:07, Chris Brannon wrote:
> I'd probably move the declaration for speechd_sockets_status out of speechd.h,
> since the variable is now encapsulated by accessor functions.
> See the attached patch.

That sounds good. I'll look into that.

> If those two statements are true, the size of the array is bounded by
> a constant.

I think that this constant is fairly high though, might be platform
dependent etc. It's probably true that socket numbers are being
assigned by the lowest available number, but we should not
pre-suppose how other parts of the code will use sockets
and thus how dense our array will be.

Anyway, I suppose the speed difference between hash table
implementation and array implementation is irrelevant
in comparison with tasks which are really time consuming
(speech synthesis, transfer of audio data between processes...).

This is separate from the issue whether we are leaking file
descriptors, which should be fixed in any case.

Best regards,
Hynek Hanke

reply via email to

[Prev in Thread] Current Thread [Next in Thread]