speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] clean up and optimize get_output_module


From: Chris Brannon
Subject: [PATCH 1/2] clean up and optimize get_output_module
Date: Mon, 16 Aug 2010 14:36:49 -0500

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Trevor Saunders <trev.saunders at gmail.com> writes:

> - reorganize the function to return if we have a module, to remove
> nesting.

Your code is correct, but your indentation is wrong.  I wouldn't have
noticed it if I hadn't looked at it with Emacspeak's audio-indent mode.
Looks like you preserved some of the previous indentation when you moved
code around.

I'm not really sure what to do here.  I could re-indent it, but that
doesn't seem in line with the code-review policy.
Mind resending?

- -- Chris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkxpk1EACgkQg6Dbfc6NLuigwwCePW5guNYux37/fo8YlvOHKtJm
N8gAn2dCod17G5+6N7rwZUxJEH+YREOZ
=8Xsg
-----END PGP SIGNATURE-----



reply via email to

[Prev in Thread] Current Thread [Next in Thread]