[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/3] spd-conf revised to reflect the current state

From: Andrei Kholodnyi
Subject: [PATCH 1/3] spd-conf revised to reflect the current state
Date: Fri, 27 Aug 2010 13:28:00 +0200

Hi Hynek,

here are my remarks. Some of them however are not directly related to
this patch, rather to config.py itself

> +# Copyright (C) 2008,2010 Brailcom, o.p.s.
a short description might help to understand what this module is doing

> + ? ? ? ?os.system("espeak \"Type in\"")
why are several synths hardcoded inside? I'd rather expect a dynamic
behavior instead.
E.g. if I configured --without-festival, I do not expect to see any
menus or tests associated with it.

> ? ? def test_alsa(self):
the same for the audio outputs, it should be dynamic
we are probably missing an API to retrieve supported audio backends.

> +            assert(0)
Do we really need this assert? IMO asserts are good for debugging, but
not for the stable sw.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]